forked from torvalds/linux
-
Notifications
You must be signed in to change notification settings - Fork 115
arm64: dts: apple: M3 SMC, NVMe, MTP, OPP and cpufreq, and J613 board #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
IntegralPilot
wants to merge
9
commits into
AsahiLinux:bits/001-devicetree-m3
Choose a base branch
from
IntegralPilot:bits/001-devicetree-m3
base: bits/001-devicetree-m3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
arm64: dts: apple: M3 SMC, NVMe, MTP, OPP and cpufreq, and J613 board #445
IntegralPilot
wants to merge
9
commits into
AsahiLinux:bits/001-devicetree-m3
from
IntegralPilot:bits/001-devicetree-m3
+507
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The board numbers listed in t8122-jxxx.dtsi (J513, J515) were used internally for M3 MacBook Air prototypes and appear in leaks [0], however, no released product seems to exist with them, with the M3 MacBook Air line instead using J613 and J615 [1][2]. Thus, correct these numbers. [0] https://9to5mac.com/2023/04/10/15-inch-macbook-air-panel -production-reportedly-ramping-up-ahead-of-upcoming-launch/ [1] https://en.wikipedia.org/wiki/List_of_Apple_codenames [2] My own personal testing on my 13-inch M3 MacBook Air Signed-off-by: Michael Reeves <michael.reeves077@gmail.com>
In the Apple M3 (t8122) device tree: - Add the following properties to each CPU node - operating-points-v2 - capacity-dmips-mhz - performance-domains - Add operating point tables for p-cores and e-cores - Add cpufreq hardware controller nodes (for both p-cluster and e-cluster) Signed-off-by: Michael Reeves <michael.reeves077@gmail.com>
Adds the System Management Contorller (SMC) to the Apple M3 SoC (t8122) device tree, including the SMC mailbox and the SMC itself, with GPIO and hwmon children. Signed-off-by: Michael Reeves <michael.reeves077@gmail.com>
|
Thanks! This works for me, although I pushed an MTP SRAM address tweak to IntegralPilot#2 (which you need to see the RTKit log). |
The internal keyboard and trackpad HID on MacBook variants of the Apple M3 (t8122) SoC are connected through a Apple -developed protocol called DockChannel and mediated by a coprocessor known as the Multi-Touch Processor (MTP). This commit adds the nessecary device tree nodes to the M3's device tree for internal HID to work. It is disabled by default, to be enabled only in MacBook board files where it is tested and confirmed to work. Co-developed-by: Alyssa Milburn <amilburn@zall.org> Signed-off-by: Alyssa Milburn <amilburn@zall.org> Signed-off-by: Michael Reeves <michael.reeves077@gmail.com>
On Apple Silicon, NVMe communication is mediated by a coprocessor known as the ANS, and protected by its own IOMMU known as the SART. Add the following nodes to the M3 (t8122) device tree: - Mailbox for the ANS coprocessor - SART (IOMMU for the ANS coprocessor) - The NVMe / ANS coprocessor itself Signed-off-by: Michael Reeves <michael.reeves077@gmail.com>
Add a device tree for the Apple MacBook Air (13-inch, M3, 2024) board variant of the M3 (t8122), known as J613. It enables and configures the keyboard backlight and internal HID nodes, as it is a laptop variant which has these devices. Also add this new device tree to the Makefile, so it is built. Signed-off-by: Michael Reeves <michael.reeves077@gmail.com>
9e5ae5f to
f097126
Compare
Author
|
Thank you! I fixed the SRAM issue and added you as Co-developed-by for that commit, can see RTKit logs now. |
This only includes the first port, because it's the only port that is present on my hardware, and only includes the pwren gpio for J613. Uses the t6020 base compatible as that is what the M3 hardware appears to be compatible with, rather than the configuration applied by the generic base compatible. Signed-off-by: Alyssa Milburn <amilburn@zall.org> Co-developed-by: Michael Reeves <michael.reeves077@gmail.com> Signed-off-by: Michael Reeves <michael.reeves077@gmail.com>
Apple Silicon Macs use two types of IOMMU, SART (for NVMe) and DART (for everything else). On M3 (t8122), the SART is compatible with the t6000 (M1 Pro/Max) one and the DART is compatible with the t8110 (A15) one. Thus, add a t8122 enum variant to the compatibles, but leave the base compatibles unchanged. Signed-off-by: Michael Reeves <michael.reeves077@gmail.com>
The mailbox on M3 (t8122) is compatible with asc-mailbox-v4, so add the t8122 compatible variant to enum section of the v4 mailbox section. Signed-off-by: Michael Reeves <michael.reeves077@gmail.com>
f097126 to
e320a67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.