use java 11 instead of java 9 + basic compilation #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed reference to ComprehensiveZmanimCalendar instead of non-existing ComplexZmanimCalendar stubbed missing methods to ComprehensiveZmanimCalendar
changed reference to ComprehensiveZmanimCalendar instead of non-existing ComplexZmanimCalendar stubbed missing methods to ComprehensiveZmanimCalendar
KosherJava
reviewed
Jan 30, 2026
|
|
||
| public Date getSofZmanTfilaFixedLocal() { | ||
| return null; | ||
| } |
Owner
There was a problem hiding this comment.
These were intended for removal. They had forRemoval=true. We should not add them back in
KosherJava
reviewed
Jan 30, 2026
| public Date getBainHasmashosYereim2Point1Degrees() { | ||
| return null; | ||
| } | ||
|
|
Owner
There was a problem hiding this comment.
All of the methods above were spelled Hasmasos. There was already renamed Hashmashos (adding the H back in). If test cases broke for these, we should tweak the spelling to the version with an H.
KosherJava
reviewed
Jan 30, 2026
|
|
||
| public Date getSofZmanTfilahAteretTorah() { | ||
| return null; | ||
| } |
Owner
There was a problem hiding this comment.
@elijulian , The above three were intended for removal as per the deprecation warning.
KosherJava
reviewed
Jan 30, 2026
Comment on lines
+6
to
+9
| import java.io.BufferedWriter; | ||
| import java.io.File; | ||
| import java.io.FileWriter; | ||
| import java.io.IOException; |
Owner
There was a problem hiding this comment.
@elijulian , were these imports really used? Was this due to the JDK update?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed reference to ComprehensiveZmanimCalendar instead of non-existing ComplexZmanimCalendar stubbed missing methods to ComprehensiveZmanimCalendar