asyncio #565
Draft
asyncio #565
+827
−275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forgot to add this to previous commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #438
Note
This is essentially a rewrite so I will try and include things we could understand would have been better in hindsight (e.g. static typing).
Do tell me what you think of the changes I made to the original concept. It is very much work-in-progress.
I will be adding docs as i go here
Changes
This will restructure scratchattach into a sync_api and async_api (probably using greenlet). For now, the async api itself needs to be made first. I am opting for httpx because it can be reused for sync and async.
Tests
Tests will be added in the format
test_{[a]sync}_{name}.py.