feat: add SSH support for plugin_marketplaces to enable private repositories #885
+217
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itories Add support for SSH URLs in the plugin_marketplaces parameter, enabling users to install plugins from private Git repositories that require SSH authentication. This is particularly useful for private GitHub/GitLab repositories where HTTPS would require access tokens. Changes: - Added SSH_URL_REGEX pattern to validate git@host:path/repo.git format - Updated validateMarketplaceInput() to accept both HTTPS and SSH URLs - HTTP URLs remain rejected (only HTTPS and SSH are supported for security) - SSH URLs bypass URL constructor validation as they're not HTTP-compatible Testing: - Added 16 new test cases covering SSH URL validation - Tests cover GitHub, GitLab, and custom hostnames - Tests verify rejection of invalid SSH formats (missing .git, wrong separator, etc.) - Tests verify mixed marketplace support (HTTPS + SSH + local paths) - Tests confirm HTTP URLs are properly rejected Documentation: - Updated action.yml with SSH format description and example - Updated base-action/action.yml with SSH format description and example - Updated docs/usage.md with SSH support information Supported formats: - HTTPS: https://github.com/user/repo.git - SSH: git@github.com:user/repo.git - Local paths: ./path, /absolute/path, ../relative/path Example usage: plugin_marketplaces: | https://github.com/public/marketplace.git git@github.com:private/marketplace.git ./local-plugins/marketplace This change is backward compatible - existing HTTPS URLs continue to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for SSH URLs in the plugin_marketplaces parameter, enabling users to install plugins from private Git repositories that require SSH authentication. This is particularly useful for private GitHub/GitLab repositories where HTTPS would require access tokens.
Changes:
Testing:
Documentation:
Supported formats:
Example usage:
plugin_marketplaces: | https://github.com/public/marketplace.git git@github.com:private/marketplace.git ./local-plugins/marketplace
This change is backward compatible - existing HTTPS URLs continue to work.