Add validation tests for GenAIGenerateContentOperator #61262
+54
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
1 task
shahar1
reviewed
Jan 30, 2026
Contributor
shahar1
left a comment
shahar1
left a comment
There was a problem hiding this comment.
Good start!
Personally I don't find the tests you've implemented too practical, as ususally the type hints help us with figuring out such discrepancies (you could retain the tests though, they're not harmful 🙂).
Could you please try to test the execute method for the case where all required parameters are given?
Try to look at unit tests of other providers and learn how mocking works.
Please let me know if you need some direction.
providers/google/tests/unit/google/cloud/operators/test_gen_ai.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds validation-focused unit tests for
GenAIGenerateContentOperatorto ensure the operator fails fast when required parameters are missing.
This work contributes to #61261.
Notes: