-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix mvn warnings #10909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mvn warnings #10909
Conversation
|
@blueorangutan package |
|
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR resolves various build-time warnings by updating plugin versions, correcting Python setup scripts, and aligning Maven coordinates for MySQL Connector/J. Key changes include:
- Adjusted Python packaging scripts (
setup.py,mvn-setup.py) to fix type and regex warnings. - Added a minimal
README.mdfor the Marvin client. - Updated Maven plugin versions (properties-maven-plugin, buildnumber-maven-plugin) and migrated MySQL Connector to
com.mysql:mysql-connector-j.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/marvin/setup.py | Switched platforms from tuple to list to satisfy setuptools. |
| tools/marvin/mvn-setup.py | Made regex literal raw string to avoid invalid escape warning. |
| tools/marvin/README.md | Added basic project README. |
| tools/devcloud4/pom.xml | Bumped properties-maven-plugin to version 1.2.0. |
| tools/devcloud-kvm/pom.xml | Bumped properties-maven-plugin to version 1.2.0. |
| pom.xml | Rebased MySQL connector to com.mysql:mysql-connector-j and removed duplicate. |
| plugins/network-elements/tungsten/pom.xml | Updated MySQL connector coordinates for test scope. |
| plugins/network-elements/globodns/pom.xml | Updated MySQL connector coordinates for test scope. |
| framework/db/pom.xml | Updated MySQL connector coordinates. |
| engine/storage/snapshot/pom.xml | Updated MySQL connector coordinates. |
| developer/pom.xml | Bumped properties-maven-plugin to version 1.2.0. |
| client/pom.xml | Switched to buildnumber-maven-plugin, updated goals and manifest entries. |
Comments suppressed due to low confidence (2)
client/pom.xml:681
- After switching to buildnumber-maven-plugin and using its
creategoal, verify that${buildNumber}and${scmBranch}are actually populated. The plugin may require explicit<propertyName>or<branchName>configuration to match these manifest entries.
<goal>create</goal>
tools/marvin/README.md:1
- [nitpick] Consider expanding this README with basic installation or quick-start instructions (e.g., dependencies, setup commands) to help new users onboard more quickly.
# Marvin
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10909 +/- ##
============================================
- Coverage 17.88% 17.88% -0.01%
+ Complexity 16075 16074 -1
============================================
Files 5936 5936
Lines 532610 532610
Branches 65147 65147
============================================
- Hits 95265 95242 -23
- Misses 426675 426701 +26
+ Partials 10670 10667 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13486 |
|
@blueorangutan test |
|
@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-13376)
|
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm, but the tests should all pass. Is this applicable to older branches as well?
I doubt the test failure is due to my changes. I think this will be applicable to older branches as well, but I haven't verified. |
@DaanHoogland @vishesh92 |
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16333 |
weizhouapache
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
|
this should have no run-time impact, but running regression tests to be sure anyway. |
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
9952d12 to
22b48c3
Compare
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
[SF] Trillian test result (tid-15169)
|
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
Co-authored-by: dahn <daan.hoogland@gmail.com>
|
@blueorangutan package |
|
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16644 |
harikrishna-patnala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Did not observed any warnings during build
Description
This PR fixes the below warnings which appear while building cloudstack.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?