Skip to content

Conversation

@suxiaogang223
Copy link
Contributor

What problem does this PR solve?

Problem Summary:

  • Background: Table names containing $ can be created but later fail on query, causing inconsistent behavior.
  • Change: Disallow $ in table names during validation (including Unicode name mode) so creation fails fast.
  • Tests:
    • FE unit test: CreateTableCommandTest covers tbl$refs creation failure.
    • Regression test: ddl_p0/test_create_table.groovy asserts “Incorrect table name”.
  • Impact: System table access (e.g. table$partitions / table$snapshots) is unaffected; only user table creation is restricted.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@suxiaogang223
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31807 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1f6b09ddaf84283779b054adee0f17e37cc6a076, data reload: false

------ Round 1 ----------------------------------
q1	17631	5261	5060	5060
q2	2039	303	191	191
q3	10211	1311	712	712
q4	10211	847	313	313
q5	7517	2117	1936	1936
q6	197	177	146	146
q7	903	724	592	592
q8	9268	1417	1104	1104
q9	5211	4913	4849	4849
q10	6841	1945	1533	1533
q11	505	285	273	273
q12	336	377	224	224
q13	17781	4061	3267	3267
q14	230	243	215	215
q15	897	815	829	815
q16	687	680	618	618
q17	641	840	433	433
q18	6610	6477	6496	6477
q19	1228	973	612	612
q20	395	331	236	236
q21	2587	1966	1928	1928
q22	355	312	273	273
Total cold run time: 102281 ms
Total hot run time: 31807 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5320	5295	5309	5295
q2	267	343	256	256
q3	2167	2705	2270	2270
q4	1369	1764	1320	1320
q5	4257	4240	4233	4233
q6	216	179	137	137
q7	2123	2223	1910	1910
q8	2534	2360	2415	2360
q9	7695	7471	7546	7471
q10	2783	3040	2674	2674
q11	562	478	474	474
q12	724	795	595	595
q13	3881	4752	3540	3540
q14	288	328	284	284
q15	866	842	834	834
q16	721	804	697	697
q17	1140	1333	1373	1333
q18	8145	8207	8129	8129
q19	832	823	801	801
q20	2066	2188	2052	2052
q21	4566	4181	4144	4144
q22	583	546	502	502
Total cold run time: 53105 ms
Total hot run time: 51311 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.41 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1f6b09ddaf84283779b054adee0f17e37cc6a076, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.04	0.04
query3	0.26	0.08	0.08
query4	1.61	0.11	0.10
query5	0.27	0.24	0.25
query6	1.16	0.69	0.67
query7	0.03	0.02	0.02
query8	0.05	0.05	0.03
query9	0.56	0.51	0.50
query10	0.56	0.55	0.55
query11	0.13	0.10	0.10
query12	0.14	0.11	0.11
query13	0.63	0.61	0.62
query14	1.06	1.08	1.05
query15	0.89	0.86	0.87
query16	0.38	0.42	0.39
query17	1.17	1.15	1.15
query18	0.22	0.21	0.22
query19	2.08	1.98	2.02
query20	0.02	0.02	0.02
query21	15.41	0.24	0.14
query22	4.99	0.05	0.04
query23	15.81	0.29	0.11
query24	1.58	1.38	0.34
query25	0.12	0.09	0.06
query26	0.16	0.13	0.13
query27	0.12	0.06	0.06
query28	4.89	1.14	0.97
query29	12.56	3.94	3.14
query30	0.29	0.14	0.11
query31	2.84	0.64	0.40
query32	3.23	0.59	0.50
query33	3.29	3.25	3.25
query34	16.24	5.39	4.72
query35	4.80	4.82	4.81
query36	0.68	0.50	0.49
query37	0.11	0.06	0.06
query38	0.07	0.04	0.04
query39	0.05	0.03	0.03
query40	0.18	0.18	0.15
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.06	0.04	0.04
Total cold run time: 98.98 s
Total hot run time: 28.41 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants