fix: Prevent mutation of default URL patterns list in block_requests
#1702
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When url_patterns was None, the code assigned it to the module-level _DEFAULT_BLOCK_REQUEST_URL_PATTERNS constant and then called extend() on it, permanently mutating the shared default list. This caused extra_url_patterns to accumulate across all subsequent calls that used the default patterns. Fixed by creating a copy of the list before extending it. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
vdusek
added
t-tooling
vdusek
added
t-tooling
vdusek
changed the title
block_requests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1702 +/- ##
==========================================
- Coverage 92.45% 92.43% -0.02%
==========================================
Files 157 157
Lines 10482 10489 +7
==========================================
+ Hits 9691 9696 +5
- Misses 791 793 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
url_patternswasNone, the code assigned it to the module-level_DEFAULT_BLOCK_REQUEST_URL_PATTERNSconstant and then calledextend()on it, permanently mutating the shared default list. This causedextra_url_patternsto accumulate across all subsequent calls that used the default patterns.Fixed by creating a copy of the list before extending it.
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com