Email users code #2449
Draft
Email users code #2449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This starts us down the path of using Active Job, which is the preferred mechanism for jobs in Rails 7.1. Signed-off-by: jonathan.kerr <3410350+jonodrew@users.noreply.github.com>
I've taken the copy from Kimberly and put it into HTML, as we do with the rest of our emails Signed-off-by: jonathan.kerr <3410350+jonodrew@users.noreply.github.com>
This adds an additional method to the MemberMailer class. It's currently called #chaser and it sends...the chaser email. In the next commit I'll call it from a Job, or maybe a Service that's called from a Job Signed-off-by: jonathan.kerr <3410350+jonodrew@users.noreply.github.com>
Signed-off-by: jonathan.kerr <3410350+jonodrew@users.noreply.github.com>
jonodrew
force-pushed
the
email-users-code
branch
from
48dc0a3 to
5ac09e3
Compare
| .deliver_now | ||
| end.to change(MemberEmailDelivery, :count).by(1) | ||
|
|
||
| log = MemberEmailDelivery.last |
Collaborator
There was a problem hiding this comment.
Minor: When looking up records with #first or #last, and you expect there to be a record, prefer the exception-raising #first! and #last!. Those exceptions are even clearer signals, crashing earlier than "NoMethodError nil does not respond to #member".
You're making nice tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft application code - welcome to look, but not ready yet