Skip to content

Conversation

@bearomorphism
Copy link
Collaborator

@bearomorphism bearomorphism commented Jan 15, 2026

I just remembered that we already have a feature that detects if a configuration file is valid. We can include pyproject.toml in the multi config warning.

Relate #1702

Also added a test to ensure that no warning when there are both pyproject.toml (without cz settings section) and cz.toml

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.97%. Comparing base (bd02381) to head (7ae6414).
⚠️ Report is 2 commits behind head on next-release.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@               Coverage Diff                @@
##           next-release    #1803      +/-   ##
================================================
- Coverage         97.98%   97.97%   -0.01%     
================================================
  Files                60       60              
  Lines              2678     2673       -5     
================================================
- Hits               2624     2619       -5     
  Misses               54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bearomorphism bearomorphism force-pushed the multi-config-include-pyproject branch from 7514e8e to ec46a4c Compare January 15, 2026 16:39
@bearomorphism bearomorphism marked this pull request as draft January 15, 2026 17:17
@bearomorphism bearomorphism force-pushed the multi-config-include-pyproject branch 2 times, most recently from 4768276 to da1e65c Compare January 15, 2026 17:23
@bearomorphism bearomorphism marked this pull request as ready for review January 15, 2026 17:23
@bearomorphism bearomorphism force-pushed the multi-config-include-pyproject branch 2 times, most recently from ff90571 to 5eb1e1c Compare January 15, 2026 17:57
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits

@Lee-W Lee-W changed the base branch from master to next-release January 31, 2026 07:12
@Lee-W Lee-W added pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check pr-status: wait-for-modification and removed pr-status: wait-for-review labels Jan 31, 2026
@bearomorphism bearomorphism force-pushed the multi-config-include-pyproject branch from 5eb1e1c to 779c6cb Compare January 31, 2026 07:21
@bearomorphism bearomorphism force-pushed the multi-config-include-pyproject branch from 779c6cb to eda118d Compare January 31, 2026 07:24
@bearomorphism bearomorphism force-pushed the multi-config-include-pyproject branch from eda118d to 7ae6414 Compare January 31, 2026 07:26
@bearomorphism bearomorphism merged commit b0af380 into next-release Jan 31, 2026
20 checks passed
@bearomorphism bearomorphism deleted the multi-config-include-pyproject branch January 31, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check pr-status: wait-for-modification pr-status: wait-for-review type: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants