Fix #2552: Add comment reaction immediately to acknowledge command #2556
+1,348
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 30, 2026 01:13
Move CreateCommentReaction call earlier in the flow to provide immediate user feedback. Previously, the reaction was added after config loading and bot checks, meaning untrusted bots or early validation failures would never get a reaction. Now the reaction is added right after: - Verifying it's a digger command - Getting the GitHub service - Before any config loading or validation This ensures users always see acknowledgment (👀) that Digger received their command, even if it's later ignored due to: - Untrusted bot account - Draft PR restrictions - Config errors - Other validation failures Benefits: - Immediate visual feedback to users - Better UX for debugging - Transparent acknowledgment of all commands - Complements PR #2554's trusted bot handling Related: #2553
- TESTING_SUMMARY.md: Quick start guide and deployment checklist - sandbox_test_issue_2552.md: Detailed test scenarios and verification steps - test_reaction_timing.sh: Automated script to verify reaction timing in logs - ISSUE_2552_FIX.md: Complete documentation of the problem and solution These files provide everything needed to test and verify the fix works correctly in sandbox before production deployment.
Show before/after behavior with clear examples and timelines to help reviewers understand the user experience improvement.
Final summary documenting all work completed, testing status, and next steps for review and deployment.
Provides easy navigation to all documentation files with quick start guides for different audiences (reviewers, testers, developers).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2552 by moving the comment reaction (👀) earlier in the event processing flow to provide immediate user feedback.
Problem
Previously, Digger only added a reaction to comments AFTER:
This meant that if a comment was from an untrusted bot, or if config loading failed, or if other early validation checks failed, no reaction was added. Users wouldn't get any feedback that Digger had seen their command.
Solution
Move the call to happen immediately after:
Benefits
Changes
Files Modified
Code Flow Before
Code Flow After
Testing
Users can now verify that:
See for detailed test scenarios.
Related
Notes