fix(core): Ensure partially set SDK metadata options are preserved #19102
+207
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Codecov Results 📊Generated by Codecov Action |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
logaretm
reviewed
Jan 30, 2026
| }; | ||
| } | ||
|
|
||
| if (!metadata.sdk) { |
Member
There was a problem hiding this comment.
I might be missing something but isn't this doing the same check as line 20? if so metadata.sdk will always be set before it hits this line here, no?
Member
Author
There was a problem hiding this comment.
Yeah not sure why but I had a massive brain outage on this one: I added my new logic underneath the old one and forgot to delete the old one afterwards. 🤦
Found a way to make this all a bit more concise. Might even save us some bytes. 🤞 Thanks for calling this out!
logaretm
approved these changes
Jan 30, 2026
Member
logaretm
left a comment
logaretm
left a comment
There was a problem hiding this comment.
Fridays be like that, nice one!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, our
applySdkMetadatahelper in core would only apply default SDK metadata (name, packages, version) if nosdkdata at all was set. This caused incomplete SDK metadata when manually overridingsdk.settings(see #19072).This PR now ensures that only if the
nameis already set, we don't apply our default options. This should be fine-grained enough to still have correct SDK metadata inheritance. I also added a bunch of tests, sinceapplySdkMetadatahad no unit tests.To be clear, I don't think we should promote controlling IP inference via SDK metadata. However, for now, it's the only way to control IP inference in a fine-grained manner, as opposed to setting
sendDefaultPii. The long-term solution is a more fine grained Pii SDK option as we're already planning to do. I think that the metadata application now is more correct though, since this also allows other SDKs to override such settings should they need to.closes #19072