chore(web): clarify locale settings description #25562
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "deduplication_info_description": "To automatically preselect assets and remove duplicates in bulk, we look at:", | ||
| "default_locale": "Default Locale", | ||
| "default_locale_description": "Format dates and numbers based on your browser locale", | ||
| "default_locale": "Use browser locale", |
Member
There was a problem hiding this comment.
Maybe we can create a new key with "use_browser_locale" for this
Collaborator
Author
There was a problem hiding this comment.
We could, but the key is only used in the app settings so then it would also make sense to delete the "default_locale" key. I don´t know if we can then easily transfer all translations from "default_locale" to "use_browser_locale".
Do you want a new key? And then delete the old key?
Member
There was a problem hiding this comment.
yeah we can delete the old key if it is not used elsewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the English i18n of the User settings → App settings → default/custom locale. I saw a few questions about this on discord.
Capitalization is now also in line with the other settings.
Not really worthy of an actual changelog entry I guess but it's definitely a translation change :p