fix(mobile): hide latest version if disabled #25691
Merged
+44
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhthomas
commented
Jan 29, 2026
| child: Text( | ||
| serverInfoState.latestVersion.major > 0 | ||
| ? "${serverInfoState.latestVersion.major}.${serverInfoState.latestVersion.minor}.${serverInfoState.latestVersion.patch}" | ||
| serverInfoState.latestVersion!.major > 0 |
Collaborator
Author
There was a problem hiding this comment.
I'm surprised this was needed - I thought flutter/dart would know that it's safe given the above guard.
uhthomas
force-pushed
the
uhthomas/mobile-hide-latest-version
branch
from
f9dad52 to
63a2cb4
Compare
uhthomas
changed the title
Collaborator
Author
|
As mentioned in Discord, I think this is okay? We could also just leave it as is and move the check for the major version > 0 up a bit. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
uhthomas
force-pushed
the
uhthomas/mobile-hide-latest-version
branch
3 times, most recently
from
5a5916f to
d93f4d3
Compare
Member
Can we move all the build related changes to it's own PR and keep this scoped to the version changes? |
Collaborator
Author
|
You got it @shenlong-tanwen - give me a bit and I will put that in a different PR. |
If the version check feature is disabled, the server will currently send stale data to the client. In addition to no longer sending stale data, the client should also not show the latest version if the feature is disabled. This complements the server PR #25688.
uhthomas
force-pushed
the
uhthomas/mobile-hide-latest-version
branch
from
d93f4d3 to
9b9aa4a
Compare
alextran1502
approved these changes
Jan 30, 2026
alextran1502
force-pushed
the
uhthomas/mobile-hide-latest-version
branch
from
858cb5f to
ee58869
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the version check feature is disabled, the server will currently send stale data to the client. In addition to no longer sending stale data, the client should also not show the latest version if the feature is disabled.
This complements the server PR #25688.
How Has This Been Tested?
I commented out this line in
mobile/lib/providers/websocket.provider.dart:then ran the app. The row was not present. With that line, it is.
Screenshots (if appropriate)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
N/A