Add support for Long operations inside predicates #139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only tested with a small set of long operations, which did not include operations with Long values inside predicates or long values with L.
Example that would not be properly checked:
Now we can check this and see that the value is 3 and not 2 so an error.
This PR makes changes in:
LiteralLongAST node (we had LiteralInt, LiteralDouble, etc, no Long)LiteralLongthrough the full pipeline: visitor interface, Z3 translation (using mkInt for exact integersemantics), type inference, etc
long