Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 22, 2025

Updates all C# projects from .NET 8 to .NET 10 target framework with compatible package versions.

Changes

Project Files

  • Microsoft.SPID.Proxy.csproj: net8.0net10.0
  • CNS.Auth.Web.csproj: net8.0net10.0

Package Updates

Microsoft.SPID.Proxy:

  • Azure.Identity: 1.11.01.13.1 (resolves CVE GHSA-m5vv-6r4h-3vj9)
  • Azure.Extensions.AspNetCore.Configuration.Secrets: 1.3.11.3.2
  • ASP.NET Core packages: 8.0.x10.0.0
  • System.Management, System.Runtime.Caching: 8.0.010.0.0

CNS.Auth.Web:

  • ASP.NET Core packages: 8.0.x10.0.0
  • Microsoft.IdentityModel.Tokens.Saml: 6.14.08.3.1

Notes

Deprecation warnings introduced (SYSLIB0057, ASPDEPR005, SYSLIB0028) are expected for .NET 10. These APIs remain functional but should be migrated to recommended alternatives in future work:

  • X509Certificate2 constructors → X509CertificateLoader
  • ForwardedHeadersOptions.KnownNetworks → KnownIPNetworks
  • X509Certificate2.PrivateKey → GetRSAPrivateKey()
Original prompt

This section details on the original issue you should resolve

<issue_title>Update all projects to .NET 10</issue_title>
<issue_description>All the C# projects and solutions should be updated to have .NET 10 as the TargetRuntime. All the referenced packages should be updated as well to be compatible with .NET 10.

The ASP.NET Core webapps to update are available here: https://github.com/microsoft/SPID-and-Digital-Identity-Enabler/tree/main/WebApps

Ensure breaking changes don't have impact on our projects: https://learn.microsoft.com/en-us/dotnet/core/compatibility/10.0?toc=%2Fdotnet%2Ffundamentals%2Ftoc.json&bc=%2Fdotnet%2Fbreadcrumb%2Ftoc.json

</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: fume <2969850+fume@users.noreply.github.com>
Copilot AI changed the title [WIP] Update all projects to use .NET 10 as TargetRuntime Migrate all WebApp projects to .NET 10 Nov 22, 2025
Copilot AI requested a review from fume November 22, 2025 18:49
@fume fume marked this pull request as ready for review November 23, 2025 00:01
@fume fume requested a review from Copilot November 23, 2025 00:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates two ASP.NET Core web applications from .NET 8 to .NET 10 by updating the target framework and associated NuGet packages. The migration addresses both framework compatibility requirements and security vulnerabilities (CVE GHSA-m5vv-6r4h-3vj9 in Azure.Identity).

  • Updated target framework from net8.0 to net10.0 in both projects
  • Upgraded ASP.NET Core packages from 8.0.x to 10.0.0
  • Updated Azure and Microsoft Identity packages with security fixes and compatibility improvements

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
WebApps/Proxy/Microsoft.SPID.Proxy/Microsoft.SPID.Proxy.csproj Updated target framework to .NET 10 and upgraded 9 packages including Azure.Identity (security fix), ASP.NET Core, and System packages
WebApps/CNS.Auth.Web/CNS.Auth.Web.csproj Updated target framework to .NET 10 and upgraded 4 packages including ASP.NET Core packages and Microsoft.IdentityModel.Tokens.Saml

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

<PackageReference Include="Microsoft.AspNetCore.Authentication.Certificate" Version="10.0.0" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation" Version="10.0.0" />
<PackageReference Include="Microsoft.IdentityModel.Tokens.Saml" Version="8.3.1" />
<PackageReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Design" Version="8.0.8" />
Copy link

Copilot AI Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Microsoft.VisualStudio.Web.CodeGeneration.Design package is still on version 8.0.8 while the project targets .NET 10. Although this package is a development-time tool and may work across versions, consider updating to version 10.0.0 if available for consistency with other package versions and to ensure full .NET 10 compatibility.

Suggested change
<PackageReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Design" Version="8.0.8" />
<PackageReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Design" Version="10.0.0" />

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update all projects to .NET 10

2 participants