-
Notifications
You must be signed in to change notification settings - Fork 291
Fix Assert.Inconclusive in constructor to behave consistently with TestInitialize #7304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
9
commits into
main
Choose a base branch
from
copilot/fix-inconclusive-assert-behavior
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+68
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Assert.Inconclusive behavior between ctor and TestInitialize
Fix Assert.Inconclusive in constructor to behave consistently with TestInitialize
Jan 28, 2026
Youssef1313
reviewed
Jan 28, 2026
src/Adapter/MSTestAdapter.PlatformServices/Execution/TestMethodInfo.cs
Outdated
Show resolved
Hide resolved
Member
|
@copilot test fails with: |
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Contributor
Author
... Fixed in 637c67a. The issue was that
The enum ordering now matches the actual test lifecycle execution order. |
…ndle it Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Evangelink
reviewed
Jan 28, 2026
Evangelink
reviewed
Jan 28, 2026
src/Adapter/MSTestAdapter.PlatformServices/Execution/TestMethodInfo.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Evangelink
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan to fix Assert.Inconclusive behavior in constructor
TestMethodInfo.cshandles TestInitialize correctly but not constructorChanges
Simplified the fix by removing the catch block from
CreateTestClassInstanceentirely. The caller's exception handler already checks forAssertInconclusiveExceptionand sets the outcome correctly (lines 479-480). This approach:Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.