Fix isCustomTeamDefaultValue type guard to check all required properties #3315
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type guard was only checking for 'defaultValue' and 'teamDefaultValue' properties, allowing objects missing 'owner' and 'expirationDate' to pass the check. This caused runtime errors when accessing expirationDate on incomplete objects. Now checks for all four required properties of CustomTeamDefaultValue<T>.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the isCustomTeamDefaultValue type guard that was causing runtime errors when accessing properties of CustomTeamDefaultValue objects.
Changes:
- Updated the
isCustomTeamDefaultValuetype guard to check all four required properties (defaultValue,teamDefaultValue,owner,expirationDate) instead of just two, preventing objects missing required properties from passing the type guard check.
benibenj
previously approved these changes
Jan 30, 2026
benibenj
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
isCustomTeamDefaultValuetype guard was only checking fordefaultValueandteamDefaultValueproperties, allowing objects missingownerandexpirationDateto pass the check. This caused runtime errors when accessingexpirationDate:Solution
Updated the type guard to check for all four required properties of
CustomTeamDefaultValue<T>:defaultValueteamDefaultValueownerexpirationDate