Skip to content

Conversation

@lszomoru
Copy link
Member

Copilot AI review requested due to automatic review settings January 30, 2026 13:18
@lszomoru lszomoru enabled auto-merge January 30, 2026 13:18
@lszomoru lszomoru self-assigned this Jan 30, 2026
@lszomoru lszomoru added this to the January 2026 milestone Jan 30, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prevents GPG commit signing in background agent sessions by making commit options configurable through the IGitService.commit() interface. The changes address VS Code issue #291669 by adding signCommit: false to commits made in background agent worktrees.

Changes:

  • Extended IGitService.commit() interface to accept optional CommitOptions parameter
  • Updated the single call site in ChatSessionWorktreeService to explicitly disable commit signing with signCommit: false

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/platform/git/common/gitService.ts Added optional CommitOptions parameter to commit() method signature in IGitService interface
src/platform/git/vscode/gitServiceImpl.ts Updated commit() implementation to accept and pass through CommitOptions to underlying repository API
src/platform/ignore/node/test/mockGitService.ts Updated mock implementation to match new interface signature
src/platform/test/node/simulationWorkspaceServices.ts Updated test service implementation to match new interface signature
src/extension/chatSessions/vscode-node/chatSessionWorktreeServiceImpl.ts Updated the single call site to explicitly pass { all: true, noVerify: true, signCommit: false }

@lszomoru lszomoru added this pull request to the merge queue Jan 30, 2026
Merged via the queue into main with commit 50e644b Jan 30, 2026
25 checks passed
@lszomoru lszomoru deleted the lszomoru/ripe-salamander branch January 30, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants