fix(windows): handle null handle.data in libuv callbacks #26577
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
handle.datadue to race conditions during handle cleanup or event loop processingChanges
The following callbacks now safely handle null
handle.data:PipeReader.zig:
onStreamAlloc- returns empty buffer if nullonStreamRead- returns early if nullonPipeClose- returns early if nullonTTYClose- returns early if nullPipeWriter.zig:
onPipeClose- returns early if nullonTTYClose- returns early if nullwin_watcher.zig:
uvClosedCallback- returns early if nullRoot Cause
When the pipe/handle is being closed, the code sets
pipe.data = pipe(self-pointer) before calling close. Due to race conditions in Windows libuv event processing, callbacks can be invoked:The
bun.cast()function triggers Zig's runtime safety check when casting a null pointer, causing a panic.Test plan
bun bd)Fixes #26574
🤖 Generated with Claude Code