-
Notifications
You must be signed in to change notification settings - Fork 709
Update ai content and add toc #22384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/preview-top-navigation
Are you sure you want to change the base?
Update ai content and add toc #22384
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @shizn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a substantial overhaul and expansion of the documentation related to TiDB's AI features. The changes aim to provide a more structured, comprehensive, and user-friendly resource for developers looking to build AI-powered applications with TiDB. The focus is on practical guidance, diverse examples, and broad integration support to streamline the development process. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly restructures and expands the "TiDB for AI" documentation, introducing a new table of contents, a demo gallery, and numerous guides and examples. The changes are well-organized and make the documentation much more comprehensive. My review includes suggestions for improving clarity, correcting minor typos and grammatical errors, and ensuring consistency across the new documents, in line with the repository's documentation style guide.
ai/integrations/llamaindex.md
Outdated
|
|
||
| ```python | ||
| tidbvec = TiDBVectorStore( | ||
| connection_string=tidb_connection_url, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ai/guides/tables.md
Outdated
| ```python | ||
| table.update( | ||
| values={ | ||
| "content": "TiDB Cloud Starter is a fully managed, auto-scaling cloud database service" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is missing a comma at the end, which will cause a syntax error in the Python dictionary. Adding the comma will fix the code example.
| "content": "TiDB Cloud Starter is a fully managed, auto-scaling cloud database service" | |
| "content": "TiDB Cloud Starter is a fully managed, auto-scaling cloud database service", |
ai/guides/fulltext-search.md
Outdated
| (7, 'Bluetooth5.3ヘッドホン ノイズキャンセリング 没入サウンド 快適装着'), | ||
| (8, 'IPX7防水イヤホン スポーツ対応 タッチ操作 高音質音楽'), | ||
| (9, 'スポーツイヤホン 安定装着 防汗 長持ちバッテリー ワークアウト対応'), | ||
| (10, '有线ヘッドホン スタジオ级 HDサウンド 快适装着 プロ音楽体験'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - [OpenAI](embedding-openai.md) | ||
| - [OpenAI Compatible](embedding-openai-compatible.md) | ||
| - [Cohere](embedding-cohere.md) | ||
| - [Jina AI](embedding-jinaai.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| !!! info | ||
|
|
||
| `tidbcloud_free` prefix models is not required to configure the API key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ai/integrations/langchain.md
Outdated
|
|
||
| ### Step 5. Embed and store document vectors | ||
|
|
||
| TiDB vector store supports both cosine distance (`consine`) and Euclidean distance (`l2`) for measuring similarity between vectors. The default strategy is cosine distance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in consine. It should be cosine.
| TiDB vector store supports both cosine distance (`consine`) and Euclidean distance (`l2`) for measuring similarity between vectors. The default strategy is cosine distance. | |
| TiDB vector store supports both cosine distance (`cosine`) and Euclidean distance (`l2`) for measuring similarity between vectors. The default strategy is cosine distance. |
ai/integrations/langchain.md
Outdated
| ```python | ||
| search_query = f""" | ||
| SELECT | ||
| VEC_Cosine_Distance(se.embedding, :query_vector) as distance, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… updated Markdown syntax
34b5b17 to
60b8cc9
Compare
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
@shizn: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?