Sync Description #6427
Open
Sync Description #6427
+96
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
his PR fixes a bug where the application description from app.pipecd.yaml was not being reflected in the control plane immediately after adding a new application. It modifies the appconfigreporter component to bypass the commit-cache optimization when the application's description is empty. This forces an immediate re-scan and sync of the configuration, ensuring the description is populated without requiring a subsequent git commit.
Why we need it:
Currently, when an application is added (especially via suggestion or without manual description input), the Description field in the Control Plane remains empty. The Piped agent skips syncing because the git commit hash hasn't changed relative to the previous state (or lack thereof). Users see an empty description in the UI until they push a new commit, which is confusing and inconsistent.
Which issue(s) this PR fixes:
Fixes #3426
Does this PR introduce a user-facing change?:
How are users affected by this change: The application description will now appear automatically in the Web UI shortly after adding the application, matching the value in app.pipecd.yaml.
Is this breaking change: No
How to migrate (if breaking change): N/A