Add speaker name filter to proposal review recap screen #4548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a text input filter that allows filtering proposals by speaker name in the review recap screen. The filter performs case-insensitive substring matching on the speaker's full name. Closes #4547 Co-authored-by: Marco Acierno <marcoacierno@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@claude make the name of the speaker in each row clickable and when clicked, it filters by that name |
This comment has been minimized.
This comment has been minimized.
Clicking a speaker's name in the proposal row now sets the speaker name filter input and triggers filtering, scrolling the filter into view. Co-authored-by: Marco Acierno <marcoacierno@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4548 +/- ##
=======================================
Coverage 94.15% 94.15%
=======================================
Files 353 353
Lines 10342 10342
Branches 761 761
=======================================
Hits 9738 9738
Misses 502 502
Partials 102 102 🚀 New features to boost your workflow:
|
Member
Author
|
@claude implement a easy button to clear the filter. Make it appear next to the input but also next to the speaker name row when filtering |
This comment has been minimized.
This comment has been minimized.
Add a clear button next to the speaker name filter input and next to each speaker name in proposal rows when the filter is active. Both buttons clear the filter and hide themselves when no filter is applied. Co-authored-by: Marco Acierno <marcoacierno@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a text input filter that allows filtering proposals by speaker name in the review recap screen. The filter performs case-insensitive substring matching on the speaker's full name.
Closes #4547
Generated with Claude Code