-
Notifications
You must be signed in to change notification settings - Fork 2.5k
fix package name and update version #58752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ahesford
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, please refrain from closing existing PRs and opening another to propose the same change. Not only does it create more noise and churn for project members, but it obfuscates the review history that led you to the current state of things.
Renames are generally painful but, when necessary, they require transitional packages with the old names to provide a proper upgrade path. Please grep through the repo for packages with descriptions containing the text "transitional dummy package" to see how that is done.
The commit message should be consistent with our usual style. Please look at the git history to ensure that you are consistent. Something like
xapps: update to 3.2.1, rename to xapp
would be appropriate.
| hostmakedepends="pkg-config meson ninja gettext libdbusmenu-gtk3 libdbusmenu-gtk3-devel gtk-update-icon-cache" | ||
| makedepends="glib-devel dbus-devel gtk+3-devel gdk-pixbuf-devel cairo-devel libX11-devel libgnomekbd-devel python3-gobject-devel" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines should be wrapped at 80 characters.
| depends="inxi xfconf" | ||
| short_desc="Cross-desktop libraries and common resources from Linux Mint" | ||
| maintainer="Michael Aldridge <maldridge@voidlinux.org>" | ||
| maintainer="Antonio Volpicelli AntoFox <nioanto@live.it>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't kidnap packages from other maintainers, and also defer adoption until you've established a history of reliable package maintenance. Finally, ping the template maintainer when you touch a package. @the-maldridge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feedback and guidance. I apologize for:
- Closing the original PR - I understand now that this creates unnecessary noise and loses review history
- Attempting to change the maintainer without permission - I've restored the original maintainer
I've now:
- Added the transitional dummy package for xapps
- Corrected hostmakedepends and makedepends
- Force-pushed to update this PR with the changes
I appreciate your patience as I learn the project's workflow and standards
Testing the changes
New package